Show theme values (and pixel/color equivalents) in hovers and completions #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
thecrypticace
force-pushed
the
feat/v4-show-theme-values
branch
2 times, most recently
from
4513e2f to
2a4b33f
Compare
thecrypticace
force-pushed
the
feat/v4-show-theme-values
branch
from
8d2f0f7 to
eb93db6
Compare
This lets users see the current theme value _and_ pixel/color equivalents.
thecrypticace
force-pushed
the
feat/v4-show-theme-values
branch
from
d2bd6b1 to
43ac528
Compare
RobinMalfait
approved these changes
Dec 10, 2024
|
Fantastic. I'm going to make some changes to the completion snippets so they're more usable. |
packages/tailwindcss-language-server/tests/completions/completions.test.js
Outdated
Show resolved
Hide resolved
RobinMalfait
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089
In v4 when we switched to using just
var(--some-theme-key)in declarations instead of including fallbacks this had the side-effect of hiding pixel and color equivalents. This PR brings those back.